fix: improve terminal integration setting label clarity #7225
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Changed 'Disable terminal shell integration' to 'Use fallback terminal mode' - Updated all 18 translation files with clearer, positive phrasing - Added clarification in description that unchecked (default) uses VSCode integration This resolves user confusion about the double-negative phrasing where unchecking 'Disable...' actually meant enabling the feature. Fixes #7224
dosubot
bot
added
size:XS
![roomote[bot]](https://avatars.githubusercontent.com/in/1546624?s=60&v=4){kind=small}
| "label": "Disable terminal shell integration", | ||
| "description": "Enable this if terminal commands aren't working correctly or you see 'Shell Integration Unavailable' errors. This uses a simpler method to run commands, bypassing some advanced terminal features. <0>Learn more</0>" | ||
| "label": "Use fallback terminal mode", | ||
| "description": "Enable this if terminal commands aren't working correctly or you see 'Shell Integration Unavailable' errors. This uses a simpler method to run commands, bypassing VSCode's advanced terminal features. When unchecked (default), Roo Code uses VSCode's terminal shell integration for better command tracking. <0>Learn more</0>" |
Contributor
Author
There was a problem hiding this comment.
Nice improvement to the UX here! The positive phrasing is much clearer. Though I wonder if we should also update the other language translations with the same enhanced description that clarifies the default behavior? Currently only English mentions "When unchecked (default), Roo Code uses VSCode's terminal shell integration for better command tracking."
hannesrudolph
added
the
Issue/PR - Triage
Member
|
More info needed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes the confusing "Disable terminal shell integration" checkbox label that was causing user confusion due to its double-negative phrasing.
Problem
The user reported in #7224 that the checkbox label "Disable terminal shell integration" was confusing because:
This double-negative phrasing (unchecking "Disable..." to enable) was counterintuitive and led to confusion about what state the setting was actually in.
Solution
Changed the label from negative to positive phrasing:
Also updated the description to clarify that when unchecked (default), Roo Code uses VSCode's terminal shell integration.
Changes
Testing
Fixes #7224
Important
This PR updates the terminal integration setting label to "Use fallback terminal mode" and clarifies its description across 18 language translation files to resolve user confusion.
settings.jsonfiles.settings.jsonforen,ru,tr,vi,zh-CN, andzh-TW.This description was created by
for f916438. You can customize this summary. It will automatically update as commits are pushed.